test: cleanup test-child-process-stdio.js #8584
Conversation
mscdex
added
the
child_process
- refactor vars to const and let issue: nodejs/code-and-learn#56(comment) modified file: test/parallel/test-child-process-stdio.js refactor variable declaration "var common" to "const common" refactor variable declaration "var assert" to "const assert" refactor variable declaration "var options" to "let options" refactor variable declaration "var child" to "let child"
pmatzavin
force-pushed
the
test-cleanup-test-child-process-stdio
branch
from
118807c
to
f8f92e4
Compare
|
Added a more detailed description of change into the commit message, referring to the source code and the git issue. |
| var options = {stdio: ['pipe']}; | ||
| var child = common.spawnPwd(options); | ||
| let options = {stdio: ['pipe']}; | ||
| let child = common.spawnPwd(options); | ||
|
|
||
| assert.notEqual(child.stdout, null); | ||
| assert.notEqual(child.stderr, null); |
There was a problem hiding this comment.
You can change assert.notStrictEqual and assert.strictEqual in this test file, too :)
There was a problem hiding this comment.
@addaleax If i understood that correctly:
Do you mean that i should replace equal with strictEqual and replace notEqual with notStrictEqual ?
In that case will there be any inconsistencies because of the fact that the assertions in this file are against null and:
undefined === null // equals false
undefined !== null // equals true
For example:
assert.notStrictEqual(undefined, null) // this will pass
assert.strictEqual(undefined, null) // this will not pass
There was a problem hiding this comment.
@pmatzavin Sorry for the late reply! Yes, that’s what I meant. Just to be clear, notStrictEqual corresponds to !== and strictEqual to ===, and we usually do want the strict tests exactly to catch things like accidentally relying on undefined == null.
issue: nodejs/code-and-learn#56(comment) modified file: test/parallel/test-child-process-stdio.js Replace the equal assetion with strictEqual. Replace the notEqual assertion with strictNotEqual.
Refs: nodejs/code-and-learn#56(comment) Replace the equal assetion with strictEqual. Replace the notEqual assertion with strictNotEqual. PR-URL: #8584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
|
Landed in 078bf68. Thank you! |
Refs: nodejs/code-and-learn#56(comment) Replace the equal assetion with strictEqual. Replace the notEqual assertion with strictNotEqual. PR-URL: #8584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
Refs: nodejs/code-and-learn#56(comment) Replace the equal assetion with strictEqual. Replace the notEqual assertion with strictNotEqual. PR-URL: #8584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
issue: nodejs/code-and-learn#56(comment)
modified file: test/parallel/test-child-process-stdio.js
refactor variable declaration "var common" to "const common"
refactor variable declaration "var assert" to "const assert"
refactor variable declaration "var options" to "let options"
refactor variable declaration "var child" to "let child"