Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: emit IPC messages on next tick #6909

Merged
merged 4 commits into from
May 24, 2016
Merged

child_process: emit IPC messages on next tick #6909

merged 4 commits into from
May 24, 2016

Commits on May 24, 2016

  1. child_process: emit IPC messages on next tick 

    Currently, if an IPC event handler throws an error, it can
cause the message to not be consumed, leading to messages piling
up. This commit causes IPC events to be emitted on the next tick,
allowing the channel's processing logic to move forward as
normal.

Fixes: nodejs#6561
PR-URL: nodejs#6909
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
    @cjihrig
    cjihrig committed May 24, 2016
    Configuration menu
    Copy the full SHA
    d59917b View commit details
    Browse the repository at this point in the history

  2. test: verify IPC messages are emitted on next tick 

    The test in this commit runs correctly if IPC messages are
properly consumed and emitted. Otherwise, the test times out.

Fixes: nodejs#6561
PR-URL: nodejs#6909
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @santigimeno @cjihrig
    santigimeno authored and cjihrig committed May 24, 2016
    Configuration menu
    Copy the full SHA
    dd21bd9 View commit details
    Browse the repository at this point in the history

  3. cluster: close ownerless handles on disconnect() 

    When a worker is disconnecting, it shuts down all of the handles
it is waiting on. It is possible that a handle does not have an
owner, which causes a crash. This commit closes such handles
without accessing the missing owner.

Fixes: nodejs#6561
PR-URL: nodejs#6909
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
    @cjihrig
    cjihrig committed May 24, 2016
    Configuration menu
    Copy the full SHA
    aadfe6c View commit details
    Browse the repository at this point in the history

  4. test: test cluster worker disconnection on error 

    This test checks that ownerless cluster worker handles are closed
correctly on disconnection.

Fixes: nodejs#6561
PR-URL: nodejs#6909
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
    @santigimeno @cjihrig
    santigimeno authored and cjihrig committed May 24, 2016
    Configuration menu
    Copy the full SHA
    f0a07d9 View commit details
    Browse the repository at this point in the history