Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add logging for test-debug-port-cluster #6769

Closed
wants to merge 2 commits into from
Closed

test: add logging for test-debug-port-cluster #6769

wants to merge 2 commits into from

Commits on May 16, 2016

  1. test: add logging for test-debug-port-cluster 

    The test is currently flaky and CI provides no real information because
the test times out rather than failing on an assertion. Add logging to
gather more information about the failure.

Refs: nodejs#6754
    @Trott
    Trott committed May 16, 2016
    Configuration menu
    Copy the full SHA
    f73296a View commit details
    Browse the repository at this point in the history

  2. test: fix test-debug-port-cluster flakiness 

    Remove port increment by `1337` which appears to sometimes result in a
port that is already in use. There is no reason not to use
`common.PORT`.
    @Trott
    Trott committed May 16, 2016
    Configuration menu
    Copy the full SHA
    b0a772f View commit details
    Browse the repository at this point in the history