Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move the readme newcomers section #6681

Merged
merged 1 commit into from
May 11, 2016

Conversation

Fishrock123
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Move the newcomers section to be more noticeable to those who it will be needed by.

Also removed some entries that are now effectively duplicates. They are all in the above section.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 10, 2016
@MylesBorins
Copy link
Contributor

great idea LGTM

@JungMinu
Copy link
Member

LGTM

1 similar comment
@estliberitas
Copy link
Contributor

LGTM

Move the newcomers section to be more noticeable to those who it will
be needed by.
Also removed some entries that are now effectively duplicates.
They are all in the above section.

PR-URL: nodejs#6681
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Alexander Makarenko <[email protected]>
@Fishrock123
Copy link
Contributor Author

Thanks, landed in 52b95f1

@Fishrock123 Fishrock123 merged commit 52b95f1 into nodejs:master May 11, 2016
@Fishrock123
Copy link
Contributor Author

Thanks, landed in 52b95f1

@Fishrock123 Fishrock123 deleted the readme-newcomers branch May 11, 2016 15:11
evanlucas pushed a commit that referenced this pull request May 17, 2016
Move the newcomers section to be more noticeable to those who it will
be needed by.
Also removed some entries that are now effectively duplicates.
They are all in the above section.

PR-URL: #6681
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Alexander Makarenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
Move the newcomers section to be more noticeable to those who it will
be needed by.
Also removed some entries that are now effectively duplicates.
They are all in the above section.

PR-URL: #6681
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Alexander Makarenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
Move the newcomers section to be more noticeable to those who it will
be needed by.
Also removed some entries that are now effectively duplicates.
They are all in the above section.

PR-URL: #6681
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Alexander Makarenko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Move the newcomers section to be more noticeable to those who it will
be needed by.
Also removed some entries that are now effectively duplicates.
They are all in the above section.

PR-URL: #6681
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Alexander Makarenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Move the newcomers section to be more noticeable to those who it will
be needed by.
Also removed some entries that are now effectively duplicates.
They are all in the above section.

PR-URL: #6681
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Alexander Makarenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants