readline: remove deprecated methods #6423
Conversation
cjihrig
added
readline
|
LGTM. For anybody who wants to look it up, these were deprecated in #3862. |
|
LGTM. I have used |
|
LGTM |
https://github.com/sindresorhus/is-fullwidth-code-point |
|
LGTM is CI passes. |
|
No comments after review. |
|
LGTM, if CI is green. |
|
CI is green. CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/229/ |
|
@nodejs/ctc ... any objections on this assuming CITGM is good? |
|
@jasnell what is your take on the CITGM results? |
|
The body-parser and glob failures are known and unrelated. |
|
Failure from ws Looks like it could be flaky... I've just released a new version of CITGM which should make the results much cleaner... not 100% why the tap results are truncated there... might be something wrong with the reporter, will dig into that https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/231/ |
This commit removes the deprecated exports getStringWidth(), stripVTControlCharacters(), and isFullWidthCodePoint(). It also removes codePointAt() in its entirety, as it was deprecated and not being used by core. Refs: nodejs#3862 PR-URL: nodejs#6423 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This commit removes the deprecated exports getStringWidth(), stripVTControlCharacters(), and isFullWidthCodePoint(). It also removes codePointAt() in its entirety, as it was deprecated and not being used by core. Refs: nodejs#3862 PR-URL: nodejs#6423 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Checklist
Affected core subsystem(s)
readline
Description of change
This commit removes the deprecated exports
getStringWidth(),stripVTControlCharacters(), andisFullWidthCodePoint(). It also removescodePointAt()in its entirety, as it was deprecated andnot being used by core.