doc: clarify stdout/stderr arguments to callback #6015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
doc
|
@nodejs/documentation |
|
LGTM, but the commit log says |
|
heh, sigh... it's late |
jasnell
force-pushed
the
doc-clarify-fs-doc
branch
from
a0e0a88
to
746a543
Compare
|
Fixed |
|
LGTM |
| The `stdout` and `stderr` arguments passed to the callback will contain the | ||
| stdout and stderr output of the child process. By default, Node.js will decode | ||
| the output as UTF-8 and pass strings to the callback. The `encoding` option | ||
| (see below) can be used to specify the character encoding used to decode the |
There was a problem hiding this comment.
I would either link to encoding or just leave off the (see below). These things tend to become wrong when things get moved around.
Clarify that the arguments to child_process.execFile and child_process.exec callback can be Buffer or strings. Fixes: nodejs#3389
jasnell
force-pushed
the
doc-clarify-fs-doc
branch
from
746a543
to
8c8910e
Compare
|
@cjihrig ... pulled out the |
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Apr 3, 2016
Clarify that the arguments to child_process.execFile and child_process.exec callback can be Buffer or strings. Fixes: #3389 PR-URL: #6015 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 6fd26dc |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2016
Clarify that the arguments to child_process.execFile and child_process.exec callback can be Buffer or strings. Fixes: #3389 PR-URL: #6015 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
Clarify that the arguments to child_process.execFile and child_process.exec callback can be Buffer or strings. Fixes: #3389 PR-URL: #6015 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
existing APIs, or introduces new ones)?
Affected core subsystem(s)
doc
Description of change
Clarify that the arguments to fs.execFile and fs.exec callback can be Buffer or strings.
Fixes: #3389