Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: don't bother making a copy of the options #593

Closed
wants to merge 1 commit into from
Closed

http: don't bother making a copy of the options #593

wants to merge 1 commit into from

Commits on Jan 24, 2015

  1. http: don't bother making a copy of the options 

    Alternative to #592. The `options` object is never overwritten, so making a copy is not necessary.

This solves issues such as https://github.com/petkaantonov/urlparser/issues where the options object is created from a constructor.
    @jonathanong
    jonathanong committed Jan 24, 2015
    Configuration menu
    Copy the full SHA
    9e1d070 View commit details
    Browse the repository at this point in the history