Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: simplify hook running logic #55963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test_runner: simplify hook running logic #55963

wants to merge 1 commit into from
+21 −25

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 23, 2024 •
edited
Loading

This commit removes some asynchronous logic from the runHook() method and replaces ArrayPrototypeReduce() with a for loop.

@cjihrig
test_runner: simplify hook running logic
f74fddd 
This commit removes some asynchronous logic from the runHook()
method and replaces ArrayPrototypeReduce() with a for loop.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 23, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (3178a76) to head (f74fddd).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55963   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         653      653           
  Lines      187852   187852           
  Branches    35888    35886    -2     
=======================================
+ Hits       165295   165306   +11     
+ Misses      15729    15724    -5     
+ Partials     6828     6822    -6
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 96.97% <100.00%> (ø)

... and 25 files with indirect coverage changes

---- 🚨 Try these New Features:

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63674/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@pmarchini pmarchini pmarchini approved these changes

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @jasnell @aduh95 @pmarchini @atlowChemi