From a2d8afcebfe751f27453e6ee404446fc4190a44a Mon Sep 17 00:00:00 2001 From: RafaelGSS <rafael.nunu@hotmail.com> Date: Wed, 13 Nov 2024 10:37:32 -0300 Subject: [PATCH 1/3] doc: include git node release --promote to steps Refs: https://github.com/nodejs/node-core-utils/pull/835 --- doc/contributing/releases.md | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 400aa51fb2667d..406c525af72507 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -704,12 +704,23 @@ the build before moving forward. Use the following list as a baseline: ### 11. Tag and sign the release commit -Once you have produced builds that you're happy with, create a new tag. By -waiting until this stage to create tags, you can discard a proposed release if -something goes wrong or additional commits are required. Once you have created a -tag and pushed it to GitHub, you _**must not**_ delete and re-tag. If you make -a mistake after tagging then you'll have to version-bump and start again and -count that tag/version as lost. +Once you have produced builds that you're happy with you can either run +`git node release -S --promote` + +```console +$ git node release -S --promote https://github.com/nodejs/node/pull/XXXX +``` + +to automate the remaining steps until step 16 or you can perform it manually +following the below steps. + +*** + +Create a new tag: By waiting until this stage to create tags, you can discard +a proposed release if something goes wrong or additional commits are required. +Once you have created a tag and pushed it to GitHub, you _**must not**_ delete +and re-tag. If you make a mistake after tagging then you'll have to version-bump +and start again and count that tag/version as lost. Tag summaries have a predictable format. Look at a recent tag to see: From 51c343fd90113034531aa3cfd3895ac66db885e2 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga <rafael.nunu@hotmail.com> Date: Wed, 13 Nov 2024 10:52:50 -0300 Subject: [PATCH 2/3] Update doc/contributing/releases.md Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> --- doc/contributing/releases.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 406c525af72507..52a2aaa48bac31 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -707,8 +707,8 @@ the build before moving forward. Use the following list as a baseline: Once you have produced builds that you're happy with you can either run `git node release -S --promote` -```console -$ git node release -S --promote https://github.com/nodejs/node/pull/XXXX +```bash +git node release -S --promote https://github.com/nodejs/node/pull/XXXX ``` to automate the remaining steps until step 16 or you can perform it manually From 082f8fd6f725d7b976bfcd96ee985535cd339a1c Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga <rafael.nunu@hotmail.com> Date: Wed, 13 Nov 2024 13:56:50 -0300 Subject: [PATCH 3/3] Update doc/contributing/releases.md Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> --- doc/contributing/releases.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 52a2aaa48bac31..358b49ba49fa8f 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -705,7 +705,7 @@ the build before moving forward. Use the following list as a baseline: ### 11. Tag and sign the release commit Once you have produced builds that you're happy with you can either run -`git node release -S --promote` +`git node release --promote` ```bash git node release -S --promote https://github.com/nodejs/node/pull/XXXX