Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update unflag info of import.meta.resolve #55810

Merged
merged 1 commit into from
Nov 12, 2024
Merged

doc: update unflag info of import.meta.resolve #55810

merged 1 commit into from
Nov 12, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 10, 2024 •
edited
Loading

same as title, to align with other features

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Nov 10, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 11, 2024 17:35
mcollina
mcollina approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0d29315 into nodejs:main Nov 12, 2024
38 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0d29315

@skyclouds2001 skyclouds2001 deleted the import.meta.resolve branch November 12, 2024 21:08
aduh95 pushed a commit that referenced this pull request Nov 16, 2024
@skyclouds2001 @aduh95
doc: update unflag info of import.meta.resolve
65ffb2c 
PR-URL: #55810
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 19, 2024
Merged
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@skyclouds2001 @tpoisseau
doc: update unflag info of import.meta.resolve
9e896ed 
PR-URL: nodejs#55810
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skyclouds2001 @nodejs-github-bot @mcollina @lpinca @JakobJingleheimer @aduh95