Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix import.meta.resolve crash #55777

Merged
merged 1 commit into from
Nov 11, 2024
Merged

esm: fix import.meta.resolve crash #55777

merged 1 commit into from
Nov 11, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #55518

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 8, 2024
@marco-ippolito marco-ippolito changed the title esm: fix import.meta.resolve in loader esm: fix import.meta.resolve crash Nov 8, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63489/

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (6af5c4e) to head (7622885).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55777   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         654      654           
  Lines      187757   187759    +2     
  Branches    36129    36127    -2     
=======================================
+ Hits       166003   166012    +9     
- Misses      14997    15002    +5     
+ Partials     6757     6745   -12
Files with missing lines Coverage Δ
src/node_modules.cc 78.77% <100.00%> (+0.46%) ⬆️

... and 28 files with indirect coverage changes

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63506/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63510/

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 11, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 07e2819 into nodejs:main Nov 11, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 07e2819

aduh95 pushed a commit that referenced this pull request Nov 16, 2024
@marco-ippolito @aduh95
esm: fix import.meta.resolve crash
83ba688 
PR-URL: #55777
Fixes: #55518
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 19, 2024
Merged
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@marco-ippolito @tpoisseau
esm: fix import.meta.resolve crash
1a931a3 
PR-URL: nodejs#55777
Fixes: nodejs#55518
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught error with --experimental-import-meta-resolve
4 participants
@marco-ippolito @nodejs-github-bot @anonrig @aduh95