Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: differentiate cases where cause is undefined or missing #55738

Merged
merged 3 commits into from
Nov 8, 2024
Merged

assert: differentiate cases where cause is undefined or missing #55738

merged 3 commits into from
Nov 8, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 6, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Nov 6, 2024
@aduh95 aduh95 mentioned this pull request Nov 6, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (4da8d11) to head (ec38506).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55738      +/-   ##
==========================================
- Coverage   88.40%   88.40%   -0.01%     
==========================================
  Files         654      654              
  Lines      187750   187754       +4     
  Branches    36131    36123       -8     
==========================================
+ Hits       165981   165984       +3     
- Misses      14999    15010      +11     
+ Partials     6770     6760      -10
Files with missing lines Coverage Δ
lib/internal/assert/assertion_error.js 95.36% <100.00%> (+0.01%) ⬆️
lib/internal/util/comparisons.js 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

LiviaMedeiros
LiviaMedeiros approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are only tests for not*Equal and throws, can we have tests for successful deepStrictEqual asserts?

@BridgeAR BridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 6, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/11701154572

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Nov 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63447/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63464/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6af5c4e into nodejs:main Nov 8, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6af5c4e

@aduh95 aduh95 deleted the error-cause-assert-diff branch November 8, 2024 01:26
aduh95 added a commit that referenced this pull request Nov 16, 2024
@aduh95
assert: differentiate cases where cause is undefined or missing
9862912 
PR-URL: #55738
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 19, 2024
Merged
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95 @tpoisseau
assert: differentiate cases where cause is undefined or missing
be5e819 
PR-URL: nodejs#55738
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@legendecas legendecas legendecas approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @lpinca @legendecas @BridgeAR @LiviaMedeiros