doc: improve c++ embedder API doc #55597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
normalise the headers, fixup bullet points and expand `node::IsolateData` scope for clarity.
gireeshpunathil
force-pushed
the
embedder-doc-improve
branch
from
fcb1435
to
e6fce97
Compare
marsonya
approved these changes
Oct 30, 2024
lpinca
approved these changes
Oct 30, 2024
gireeshpunathil
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 824c149 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
normalise the headers, fixup bullet points and expand `node::IsolateData` scope for clarity. PR-URL: #55597 Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
normalise the headers, fixup bullet points and expand `node::IsolateData` scope for clarity. PR-URL: nodejs#55597 Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
normalise the headers, fixup bullet points and expand `node::IsolateData` scope for clarity. PR-URL: nodejs#55597 Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalise the headers, fixup bullet points and expand
node::IsolateDatascope for clarity.