test_runner: pass options directly to TestCoverage
#55578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55578 +/- ##
==========================================
+ Coverage 87.93% 88.32% +0.39%
==========================================
Files 654 654
Lines 187686 187658 -28
Branches 35819 36049 +230
==========================================
+ Hits 165038 165746 +708
+ Misses 15849 15125 -724
+ Partials 6799 6787 -12
|
pmarchini
reviewed
Oct 29, 2024
MoLow
approved these changes
Oct 29, 2024
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
|
CI is 💚 , can someone add the commit-queue label so once 48hrs pass this can land quickly and smoothly? |
|
IIR, you can add it whenever, and once the wait time has elapsed, it will kick in automatically |
I can't, I'm not a collaborator. If I could, I would. |
pmarchini
added
the
commit-queue
|
It looks like CI stalled after everything passed, and just didn't mark itself completed. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55578 ✔ Done loading data for nodejs/node/pull/55578 ----------------------------------- PR info ------------------------------------ Title test_runner: pass `options` directly to `TestCoverage` (#55578) Author Aviv Keller <[email protected]> (@RedYetiDev) Branch RedYetiDev:options-testcoverage -> nodejs:main Labels author ready, test_runner Commits 1 - test_runner: pass `options` directly to `TestCoverage` Committers 1 - RedYetiDev <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55578 Reviewed-By: Moshe Atlow <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55578 Reviewed-By: Moshe Atlow <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 28 Oct 2024 23:00:22 GMT ✔ Approvals: 1 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/55578#pullrequestreview-2401251223 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-29T14:40:07Z: https://ci.nodejs.org/job/node-test-pull-request/63337/ - Querying data for job/node-test-pull-request/63337/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11603069194 |
|
The GitHub bot didn't count at @pmarchini's review to do a typo in the README. See #55625 |
RedYetiDev
removed
the
commit-queue-failed
rluvaton
approved these changes
Nov 1, 2024
|
Thanks @rluvaton! Now that this has two countable reviews, can someone add the commit-queue label? |
rluvaton
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9b6cea6 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR-URL: #55578 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55578 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55578 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Raz Luvaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make future modifications to the
TestCoverageclass simpler, as additional options don't need to be added to the constructor.