Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: add readOnly option #55567

Merged
merged 1 commit into from
Oct 31, 2024
Merged

sqlite: add readOnly option #55567

merged 1 commit into from
Oct 31, 2024

Conversation

tniessen
Copy link
Member

Allow opening existing SQLite databases with SQLITE_OPEN_READONLY set.

@tniessen
sqlite: add readOnly option
b14b4a3 
Allow opening existing SQLite databases with SQLITE_OPEN_READONLY set.
@tniessen tniessen added experimental Issues and PRs related to experimental features. sqlite Issues and PRs related to the SQLite subsystem. labels Oct 28, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (5d4fee8) to head (b14b4a3).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55567   +/-   ##
=======================================
  Coverage   88.42%   88.43%           
=======================================
  Files         654      654           
  Lines      187662   187676   +14     
  Branches    36118    36120    +2     
=======================================
+ Hits       165945   165966   +21     
+ Misses      14955    14950    -5     
+ Partials     6762     6760    -2
Files with missing lines Coverage Δ
src/node_sqlite.h 77.77% <100.00%> (+4.44%) ⬆️
src/node_sqlite.cc 83.33% <83.33%> (-0.04%) ⬇️

... and 24 files with indirect coverage changes

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63331/

@tniessen tniessen added the review wanted PRs that need reviews. label Oct 29, 2024
@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Oct 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit a465b20 into nodejs:main Oct 31, 2024
84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a465b20

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
@tniessen @RafaelGSS
sqlite: add readOnly option
2ec4ae7 
Allow opening existing SQLite databases with SQLITE_OPEN_READONLY set.

PR-URL: #55567
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@tniessen @louwers
sqlite: add readOnly option
21f700c 
Allow opening existing SQLite databases with SQLITE_OPEN_READONLY set.

PR-URL: nodejs#55567
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@aduh95 aduh95 mentioned this pull request Nov 6, 2024
Merged
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@tniessen @tpoisseau
sqlite: add readOnly option
16abab2 
Allow opening existing SQLite databases with SQLITE_OPEN_READONLY set.

PR-URL: nodejs#55567
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @cjihrig @RafaelGSS