Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update undici to 6.20.1 #55503

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of undici to 6.20.1.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Oct 23, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 23, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (7b5d660) to head (fc74673).
Report is 136 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55503   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files         653      653           
  Lines      187476   187476           
  Branches    36083    36084    +1     
=======================================
+ Hits       165763   165773   +10     
- Misses      14946    14952    +6     
+ Partials     6767     6751   -16     

see 24 files with indirect coverage changes

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 26, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/55503
✔  Done loading data for nodejs/node/pull/55503
----------------------------------- PR info ------------------------------------
Title      deps: update undici to 6.20.1 (#55503)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels     lib / src, needs-ci, dependencies
Commits    1
 - deps: update undici to 6.20.1
Committers 1
 - Node.js GitHub Bot <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 23 Oct 2024 16:35:43 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/55503#pullrequestreview-2389400431
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/55503#pullrequestreview-2389536808
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/55503#pullrequestreview-2389634826
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/11531116725

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit f0e5b6a into main Oct 26, 2024
84 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in f0e5b6a

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch October 26, 2024 18:52
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
PR-URL: #55503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#55503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Uzlopak
Copy link
Contributor

Uzlopak commented Nov 7, 2024

We need to backport this to v20 and v22 branch.

@marco-ippolito
@RafaelGSS
@anonrig
@mcollina

@george-roussos
Copy link

Hi, is there any updates on the backporting?

@aduh95 aduh95 added the lts-watch-v20.x PRs that may need to be released in v20.x label Nov 14, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#55503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants