doc: remove outdated remarks about highWaterMark in fs
#55462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037.
nodejs-github-bot
added
doc
lpinca
approved these changes
Oct 20, 2024
RedYetiDev
added
the
author ready
jasnell
approved these changes
Oct 20, 2024
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4320e1a |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
`Readable`'s `highWaterMark` has in fact been 64KiB since #52037. PR-URL: #55462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037. PR-URL: nodejs#55462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037. PR-URL: nodejs#55462 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readable'shighWaterMarkhas in fact been 64KiB since #52037.