Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add more labels to dep-updaters #54454

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Aug 19, 2024

This PR changes the dependency updaters to have more labels:

When amaro is updated, it will also be labeled as strip-types
When brotli is updated, it will also be labeled as zlib
When c-ares is updated, it will also be labeled as cares
When gyp-next is updated, it will also be labeled as gyp
When icu is updated, it will also be labeled as icu
When sqlite is updated, it will also be labeled as sqlite
When zlib is updated, it will also be labeled as zlib
When openssl is updated, it will also be labeled as openssl
When v8 is updated, it will also be labeled as dependencies

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 19, 2024
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you check also v8 and openssl?

@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 19, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 99f4a73 into nodejs:main Aug 22, 2024
18 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 99f4a73

RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
PR-URL: #54454
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 25, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54454
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants