From a444c218ce0713012541dd94f4bdf296756f4a6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 20 Jul 2024 11:49:53 +0200 Subject: [PATCH] deps: V8: cherry-pick 9812cb486e2b MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: [api] Remove template id from Local constructor According to GCC version 14, this is deprecated in C++20. Change-Id: Iaab14c2db56b3787e391e4d50a9099015169d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5713754 Reviewed-by: Michael Lippautz Auto-Submit: Michaël Zasso Reviewed-by: Camillo Bruni Commit-Queue: Camillo Bruni Cr-Commit-Position: refs/heads/main@{#95084} Refs: https://github.com/v8/v8/commit/9812cb486e2bfb7b72c7cee41d4ee1916dfef412 --- common.gypi | 2 +- deps/v8/include/v8-local-handle.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/common.gypi b/common.gypi index 154bbf2a0df0cb..a3057b47d34049 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.16', + 'v8_embedder_string': '-node.17', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-local-handle.h b/deps/v8/include/v8-local-handle.h index 46f7308431af0d..fd543ae3aaa4fa 100644 --- a/deps/v8/include/v8-local-handle.h +++ b/deps/v8/include/v8-local-handle.h @@ -398,8 +398,7 @@ class V8_TRIVIAL_ABI Local : public LocalBase, explicit Local(const Local& other, no_checking_tag do_not_check) : LocalBase(other), StackAllocated(do_not_check) {} - V8_INLINE explicit Local(const LocalBase& other) - : LocalBase(other) {} + V8_INLINE explicit Local(const LocalBase& other) : LocalBase(other) {} V8_INLINE static Local FromSlot(internal::Address* slot) { return Local(LocalBase::FromSlot(slot));