-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v22.5.1 proposal #53935
v22.5.1 proposal #53935
Conversation
This reverts commit ed6f45b. PR-URL: #53904 Refs: yarnpkg/berry#6398 Refs: npm/cli#7657 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Notable changes: This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms: - Crash with ``` FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available ``` - npm errors with `npm error Exit handler never called!` - yarn hangs or outputs ``` Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) ``` PR-URL: #53935 Refs: #53902 Refs: npm/cli#7657 Refs: yarnpkg/berry#6398
This comment was marked as outdated.
This comment was marked as outdated.
The Yarn symptom is that it either hangs or if not in interactive mode (CI=true) terminates mid install with exit code 0 (empty event loop) which causes commands run after that to complain that a install hasn't been done. |
ah thanks. If I update the wording I'm going to have to rerun the builds. I'm doing some final checks -- if anything comes up and the build needs to change I'll reword otherwise I think we can release as-is and reword afterwards in follow up PRs to the changelog if necessary. |
For some reason, the CITGM job installed [email protected] instead of the
|
Notable changes: This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms: - Crash with ``` FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available ``` - npm errors with `npm error Exit handler never called!` - yarn hangs or outputs ``` Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) ``` PR-URL: #53935 Refs: #53902 Refs: npm/cli#7657 Refs: yarnpkg/berry#6398
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2], so this commit ensures that CI is using this version. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2]. We are using `22.x` in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
There seems to be a regression in Node 22.5.0 which [prevents `yarn install` from running][1] and in turns prevents CI from completing successfully. This regression was [fixed in 22.5.1][2]. We are using `22.x` in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly. [1]: yarnpkg/berry#6398 [2]: nodejs/node#53935
2024-07-19, Version 22.5.1 (Current), @richardlau
Notable Changes
This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms:
FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available
#53902npm error Exit handler never called!
npm/cli#7657Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)
yarnpkg/berry#6398Commits
e2deeedc6e
] - Revert "fs: add v8 fast api to closeSync" (Aviv Keller) #53904cc @nodejs/releasers