Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: only generate specified build type files" #53580

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Revert "build: only generate specified build type files" #53580

merged 1 commit into from
Jun 26, 2024

Conversation

legendecas
Copy link
Member

This reverts commit 6cb940a.

Refs: #53511 (comment)

I think an alternative should be making the generated config.gypi works in both Release mode and Debug mode.

@legendecas legendecas requested a review from targos June 25, 2024 09:04
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 25, 2024
@targos targos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 25, 2024
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59962/

@legendecas legendecas added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @legendecas. Please 👍 to approve.

@legendecas
Copy link
Member Author

Fast-tracking the revert to fix the ninja workflow composing with make.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59967/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59970/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit ab5e58b into nodejs:main Jun 26, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ab5e58b

@legendecas legendecas deleted the build/revert-ninja branch June 26, 2024 09:51
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legendecas @nodejs-github-bot @lpinca @targos @richardlau