Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: indicate requirement on VS 17.6 or newer #53301

Merged
merged 1 commit into from
Jun 6, 2024
Merged

doc: indicate requirement on VS 17.6 or newer #53301

merged 1 commit into from
Jun 6, 2024

Conversation

legendecas
Copy link
Member

VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only.

At the moment this version requirement is only listed under the section "Optional requirements for compiling for Windows 10 on ARM".

@legendecas
doc: indicate requirement on VS 17.6 or newer
56e1615 
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 3, 2024
StefanStojanovic
StefanStojanovic approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 641 * Visual Studio 17.6.0 or newer in the Optional requirements for compiling for Windows 10 on ARM (ARM64): section can be removed since that is added in the mandatory requirements now.

@legendecas
Copy link
Member Author

Line 641 * Visual Studio 17.6.0 or newer in the Optional requirements for compiling for Windows 10 on ARM (ARM64): section can be removed since that is added in the mandatory requirements now.

You can have either one of VS 17.6 or newer, or the Build Tools when building for x64. So it is still good to explicitly say that VS 17.6 or newer is required for ARM builds.

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2b7f3d0 into nodejs:main Jun 6, 2024
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2b7f3d0

@richardlau richardlau added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Jun 6, 2024
@legendecas legendecas deleted the doc/windows branch June 6, 2024 12:58
RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
@legendecas @RafaelGSS
doc: indicate requirement on VS 17.6 or newer
7bc5f96 
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.

PR-URL: #53301
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
greyaxie

This comment was marked as spam.

Sign in to view

sophonieb pushed a commit to sophonieb/node that referenced this pull request Jun 20, 2024
@legendecas @sophonieb
doc: indicate requirement on VS 17.6 or newer
1d3b24f 
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.

PR-URL: nodejs#53301
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@legendecas @bmeck
doc: indicate requirement on VS 17.6 or newer
ed69e2f 
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.

PR-URL: nodejs#53301
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyaxie greyaxie greyaxie left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@legendecas @nodejs-github-bot @lpinca @anonrig @StefanStojanovic @VoltrexKeyva @greyaxie @richardlau