Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" #53144

Closed
wants to merge 1 commit into from
Closed

[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" #53144

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

This reverts commit 8d20b64.
Fixes: #53143

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams labels May 25, 2024
@marco-ippolito marco-ippolito mentioned this pull request May 25, 2024
Closed
@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 25, 2024 •
edited
Loading

Apparently "Revert 'Revert" is not valid commit message 😆

@marco-ippolito marco-ippolito force-pushed the feat/fix-revert-revert branch 2 times, most recently from 715d3b5 to 0600cf1 Compare May 25, 2024 06:12
@marco-ippolito marco-ippolito changed the title [v20.x backport] Revert "Revert "stream: fix cloned webstreams not being unref'd"" [v20.] Revert "Revert "stream: fix cloned webstreams not being unref'd"" May 25, 2024
@marco-ippolito marco-ippolito changed the title [v20.] Revert "Revert "stream: fix cloned webstreams not being unref'd"" [v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" May 25, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59394/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59397/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59400/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59401/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59415/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59422/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59428/

@marco-ippolito

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59439/

@marco-ippolito marco-ippolito mentioned this pull request May 27, 2024
Merged
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59448/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59457/

mcollina
mcollina approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marco-ippolito added a commit that referenced this pull request May 27, 2024
@marco-ippolito
Revert "stream: revert fix cloned webstreams not being unref'd"
cffd2cc 
This reverts commit 8d20b64.

PR-URL: #53144
Fixes: #53143
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@marco-ippolito
Copy link
Member Author

Landed in cffd2cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-ippolito @nodejs-github-bot @mcollina @RafaelGSS