doc: clarify the restrictions of catching an uncaughtException #5180
Conversation
mscdex
added
doc
|
@nodejs/ctc ... thoughts? |
|
This might be worded better to simply say that if an exception is thrown from within an Also I'm not sure if it's really useful to suggest using something like |
|
Thanks for the clarification @mscdex ... I will revise my addition |
|
@NoahRoseLedesma Can you make sure to wrap lines at 80 columns while you're at it? |
|
I have revised the entry and wrapped the text in 06f07a6 |
|
LGTM |
|
LGTM. Should we give an example? |
|
LGTM, I'm -0 on an example. I wonder if |
|
I'd replace it with |
|
Yes, exit/terminate with a non-zero status code sounds much better. |
|
Alright, the latest commit changes the wording from die to exiting with a non zero exit code. |
PR-URL: #5180 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
|
Thanks! Landed in c605c5d with slight modification to the commit title to fit 52 chars. |
PR-URL: #5180 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
PR-URL: #5180 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
PR-URL: #5180 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
PR-URL: #5180 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
This commit adds information regarding catching uncaughtExceptions to the process doc. As brought up in #5147 the documentation does not state the recursion guard implemented in 2b252ac.