Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to npm 2.14.17 #5110

Closed
wants to merge 262 commits into from
Closed

deps: upgrade to npm 2.14.17 #5110

wants to merge 262 commits into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Feb 5, 2016

Another week, another npm!

Notable changes:

r @iarna
r @Fishrock123
r @jasnell

trevnorris and others added 30 commits December 29, 2015 13:35
@trevnorris
async_wrap: call callback in destructor
dab862f 
Call a user's callback to notify that the handle has been destroyed.
Only pass the id of the AsyncWrap instance since the object no longer
exists.

The object that's being destructed should never be inspected within the
callback or any time afterward.

This commit make a breaking change. The init callback will now be passed
arguments in the order of provider, id, parent.

PR-URL: nodejs#3461
Reviewed-By: Fedor Indutny <[email protected]>
@rvagg
doc: add TSC meeting minutes 2015-10-14
33474b7 
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#3463
@rvagg
doc: add TSC meeting minutes 2015-10-21
fcb67d7 
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#3480
@mcornac
test: fix race condition in unrefd interval test
15ae55e 
Rely more on timers implementation rather than arbitrary timeouts.

Refs: nodejs#1781
PR-URL: nodejs#3550

Reviewed-By: Jeremiah Senkpiel <[email protected]>
@emilyaviva
doc: add final full stop in CONTRIBUTING.md
39056e2 
PR-URL: nodejs#3576
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@rvagg
doc: add CTC meeting minutes 2015-10-28
cf4a8d5 
PR-URL: nodejs#3661
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis
build: omit -gline-tables-only for --enable-asan
6d9d37f 
`-gline-tables-only` is a clang-only flag.  Drop it, it's not needed for
address sanitizer-enabled builds and it makes it impossible to build
with gcc.

Fixes: nodejs#3656
PR-URL: nodejs#3680
Reviewed-By: Fedor Indutny <[email protected]>
@r-52
doc: add warning about Windows process groups
595320a 
This commit adds a warning for Windows platforms. `process.kill` wont
kill a process group on Windows and instead it throws an error.

Refs: nodejs#3617
PR-URL: nodejs#3681
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mcornac
test: skip instead of fail when mem constrained
45df9f7 
The current implementation of tests for strings with length at or
exceeding kStringMaxLength allocate a temporary buffer inside a try
block to skip the test if there is insufficient memory. This commit adds
an invocation of the garbage collector after the temporary buffer is
allocated so that memory is freed for later allocations.

Change the corresponding catch block to rethrow the original exception
instead of asserting the exception message to provide more information
about the exception.

Add an additional check before trying to allocate memory to immediately
skip the test on machines with insufficient total memory.

PR-URL: nodejs#3697
Reviewed-By: Trevor Norris <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Trott
tools: Use throw new Error() consistently
327b746 
In preparation for a lint rule that will enforce `throw new Error()`
over `throw Error()`, fix the handful of instances in the code that
use `throw Error()`.

PR-URL: nodejs#3714
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
tools: enforce throw new Error() with lint rule
d96d07d 
Add linting rule requiring `throw new Error()` over `throw Error()`.

PR-URL: nodejs#3714
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@stefanmb
doc: Describe FIPSDIR environment variable
92e59e1 
As per the OpenSSL User Guide, it is possible to use the FIPSDIR
environment variable to specify a custom install path for the
validated cryptographic module.

PR-URL: nodejs#3752
Reviewed-By: Michael Dawsson <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@stefanmb
crypto: disable crypto.createCipher in FIPS mode
00f4312 
FIPS 140-2 disallows use of MD5, which is used to derive the
initialization vector and key for createCipher(). Modify
all tests to expect exceptions in FIPS mode when disallowed
API is used, or to avoid testing such API in FIPS Mode.

PR-URL: nodejs#3754
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas
test: add OS X to module loading error test
e1f2810 
Previously, this test was not supported on OS X. This change makes sure
that it is no longer skipped.

PR-URL: nodejs#3901
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@yorkie
fs,doc: use target instead of destination
a221308 
PR-URL: nodejs#3912
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Bert Belder <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@martfors
doc: move fs.existsSync() deprecation message
14c6f84 
This commit moves the deprecation message for fs.existsSync()
above the function description, making message placement
uniform across the documentation.

PR-URL: nodejs#3942
Reviewed-By: Colin Ihrig <[email protected]>
@jscissr
net: small code cleanup
80d8529 
`options` is already a param of the function.

PR-URL: nodejs#3943
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
test: add TAP diagnostic message for retried tests
50564b5 
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

PR-URL: nodejs#3960
Reviewed-By: Fedor Indutny <[email protected]>
@gireeshpunathil
test: fix time resolution constraint
3f04261 
The modification time of a file is assumed to happen at the
exact time when it was requested. As the utime API specification
delcares that the resolution of the result is 1 second,
relax the constrain to 1 second helps the test case to be
robust and consistent under different load conditions in the system

PR-URL: nodejs#3981
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@rvagg
doc: s/node.js/Node.js in readme
4290823 
PR-URL: nodejs#3998
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@tomgco
buffer: default to UTF8 in byteLength()
30b306c 
If an undefined encoding is passed to byteLength(),
assume that it is UTF8 immediately. This yields a
small speedup, as it prevents string operations on
the encoding argument.

PR-URL: nodejs#4010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
@Trott
test: use platform-based timeout for reliability
0f591e6 
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
to time.

Use a platform-based timeout to improve reliability.

PR-URL: nodejs#4015
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@stefanmb
crypto: fix native module compilation with FIPS
89c8450 
Prevent OpenSSL's fipsld from being used to link native modules
because this requires the original OpenSSL source to be
available after Node's installation.

Fixes: nodejs#3815
PR-URL: nodejs#4023
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
doc: add links and backticks around names
24117ee 
* add backticks around names
* add single quotes around event names
* add parenthesis after function names
* add internal links between different sections
* add external links to MDN for some JavaScript references
* sort the link definitions alphabetically

PR-URL: nodejs#4054
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@baloo
doc: fixup socket.remoteAddress
aa1034a 
remoteAddress may be undefined under certain conditions

Signed-off-by: Arthur Gautier <[email protected]>

PR-URL: nodejs#4198
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@jscissr
doc: document backlog for server.listen() variants
6d6e63c 
The backlog parameter is supported by all variations of
net.Server.listen(), but wasn't consistently documented. This
commit brings the documentation into a more consistent state.

Refs: nodejs#4056
PR-URL: nodejs#4025
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@bsnote
timers: optimize callback call: bind -> arrow
f0cf7d8 
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: nodejs#4038
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@santigimeno
test: fix http-many-ended-pipelines flakiness
a3394fc 
It can happen that the HTTP connection is closed before the server has received
all the requests, thus the server close condition is never reached. To solve
this, close the server when the socket is fully closed.

PR-URL: nodejs#4041
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@Trott
test: eliminate multicast test FreeBSD flakiness
24b6596 
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: nodejs#2474
PR-URL: nodejs#4042
Reviewed-By: Ben Noordhuis <[email protected]>
@mscdex
test: improve cluster-disconnect-handles test
ebfbf55 
This commit fixes two issues in test-cluster-disconnect-handles:

1. If the master's TCP connection to the worker fails, the worker
process stays alive and causes many other tests that use the same
common port number to also fail (with EADDRINUSE).

2. One particular problem that can cause the master's TCP connection
to fail is attempting an IPv6 connection to the worker when no IPv6
network interfaces are available.

PR-URL: nodejs#4084
Reviewed-By: Colin Ihrig <[email protected]>
zkat and others added 11 commits January 28, 2016 14:05
@zkat
doc: update list of personal traits in CoC
6cfc59e 
rust-lang/prev.rust-lang.org#288 landed in the Rust repo
so it seems like a good idea to just bring the updated list in.

We also received a request to do this in nodejs/inclusivity#82
so this should resolve that.

Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing
up the original issue.

Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
PR-URL: nodejs#4801
Fixes: nodejs/inclusivity#82
@MylesBorins
tools: add support for subkeys in release tools
2f38399 
Replace grep with awk to add support for subkeys

PR-URL: nodejs#4807
Reviewed-By: Rod Vagg <[email protected]>
@zkat
deps: upgrade to npm 2.14.15
6a2ea41 
PR-URL: nodejs#4872
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rebecca Turner <[email protected]>
@zkat
test: make npm tests work on prerelease node versions
c4da37b 
PR-URL: nodejs#4872
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rebecca Turner <[email protected]>
@zkat
doc: Update small error in LICENSE for npm
ce8b663 
This corresponds to npm/npm@6051a69

PR-URL: nodejs#4872
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rebecca Turner <[email protected]>
deps: upgrade openssl sources to 1.0.2f
7bd9fab 
This replaces all sources of openssl-1.0.2f.tar.gz
into deps/openssl/openssl

Fix: nodejs#4857
PR-URL: nodejs#4961
Reviewed-By: Shigeki Ohtsu <[email protected]>

deps: copy openssl header files to include dir

All symlink files in deps/openssl/openssl/include/openssl/ are removed
and replaced with real header files to avoid issues on Windows.
Two files of opensslconf.h in crypto and include dir are replaced to
refer config/opensslconf.h.

Fix: nodejs#4857
PR-URL: nodejs#4961
Reviewed-By: Shigeki Ohtsu <[email protected]>

deps: fix openssl assembly error on ia32 win32

`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>

deps: fix asm build error of openssl in x86_win32

See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

openssl: fix keypress requirement in apps on win32

Reapply b910613 .

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>

docs: update openssl UPDATING guide

the guide is now current with the steps taken to update
openssl to v1.0.2f

PR-URL: nodejs#4961
Reviewed-By: Myles Borins <[email protected]>
deps: add -no_rand_screen to openssl s_client
fcb8cae 
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: nodejs#1461
PR-URL: nodejs#1836
Reviewed-By: Ben Noordhuis <[email protected]>
@zkat
deps: upgrade to npm 2.14.16
fc446ba 
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@zkat
test: make npm tests work on prerelease node versions
9a9ac8e 
PR-URL: nodejs#4960
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@santigimeno
test: fix tls-no-rsa-key flakiness
3281c58 
In some conditions it can happen that the client-side socket is destroyed
before the server-side socket has gracefully closed, thus causing a
'ECONNRESET' error in this socket. To solve this, wait in the client-side
socket for the 'end' event before closing it.

PR-URL: nodejs#4043
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@zkat
deps: upgrade to npm 2.14.17
957f0e4
@zkat zkat added npm Issues and PRs related to the npm client dependency or the npm registry. lts-watch-v4.x labels Feb 5, 2016
@mscdex mscdex added the v4.x label Feb 6, 2016
@jasnell
Copy link
Member

jasnell commented Feb 7, 2016

LGTM

@MylesBorins
Copy link
Contributor

@zkat we ended up rebasing staging against the release branch after the security update... this PR will need to be rebased. (although we can just apply the patch)

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/67/

If citgm is green I'll go ahead and land 957f0e4 on staging

edit: local make test-npm works as expected :D

edit: citgm is happy. Failures are either expected or infra.

MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@zkat
deps: upgrade to npm 2.14.17
c478fe2 
PR-URL: #5110
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins
Copy link
Contributor

landed in c478fe2

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@zkat
deps: upgrade to npm 2.14.17
831f496 
PR-URL: nodejs#5110
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@zkat
deps: upgrade to npm 2.14.17
524b083 
PR-URL: #5110
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@zkat
deps: upgrade to npm 2.14.17
60e0bd4 
PR-URL: #5110
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@zkat
deps: upgrade to npm 2.14.17
3c05838 
PR-URL: #5110
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
This was referenced Apr 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.