Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: remove the abort listener on iterator completion #51091

Merged
merged 3 commits into from
Mar 15, 2024
Merged

events: remove the abort listener on iterator completion #51091

merged 3 commits into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. events: remove abort listener from signal in on 

    the `abortHandler` function is declared within the scope of
the `events.on` function so cannot be removed by the caller
which can lead to a memory leak
adding the abort listener using the `addAbortListener` helper
returns a disposable that can be used to clean up the listener
when the iterator is exited

Fixes: nodejs#51010
    @nbbeeken
    nbbeeken committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    95b6c27 View commit details
    Browse the repository at this point in the history

  2. add abort listener using addAbortListener util and invoke disposabl… 

    …e interface
    @nbbeeken
    nbbeeken committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    5819b36 View commit details
    Browse the repository at this point in the history

  3. test: add abort test case and check either entire event map or abort … 

    …listener list
    @nbbeeken
    nbbeeken committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    719f745 View commit details
    Browse the repository at this point in the history