From da5766b6c92750a6ad2abff33a1c1ba6e23f5b20 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Sat, 18 Nov 2023 00:20:08 +0100 Subject: [PATCH 1/4] stream: fix enumerability of ReadableStream.prototype.values --- lib/internal/webstreams/readablestream.js | 1 + test/wpt/status/streams.json | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js index a5f95596e3082a..363cce8ed3d0de 100644 --- a/lib/internal/webstreams/readablestream.js +++ b/lib/internal/webstreams/readablestream.js @@ -636,6 +636,7 @@ ObjectDefineProperties(ReadableStream.prototype, { pipeThrough: kEnumerableProperty, pipeTo: kEnumerableProperty, tee: kEnumerableProperty, + values: kEnumerableProperty, [SymbolToStringTag]: getNonWritablePropertyDescriptor(ReadableStream.name), }); diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json index fb0064a810503b..f2851bed440ab5 100644 --- a/test/wpt/status/streams.json +++ b/test/wpt/status/streams.json @@ -2,7 +2,6 @@ "idlharness.any.js": { "fail": { "expected": [ - "ReadableStream interface: async iterable", "ReadableStream interface: operation from(any)" ] } From 71f82f1341399a57ce92fd1f17a85c166aa7fc6e Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Mon, 20 Nov 2023 22:23:24 +0100 Subject: [PATCH 2/4] stream: fix enumerability of ReadableStream.from --- lib/internal/webstreams/readablestream.js | 3 +++ test/wpt/status/streams.json | 7 ------- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js index 363cce8ed3d0de..8e27bae439f8e3 100644 --- a/lib/internal/webstreams/readablestream.js +++ b/lib/internal/webstreams/readablestream.js @@ -639,6 +639,9 @@ ObjectDefineProperties(ReadableStream.prototype, { values: kEnumerableProperty, [SymbolToStringTag]: getNonWritablePropertyDescriptor(ReadableStream.name), }); +ObjectDefineProperties(ReadableStream, { + from: kEnumerableProperty, +}); function InternalTransferredReadableStream() { markTransferMode(this, false, true); diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json index f2851bed440ab5..fa97eae8320d78 100644 --- a/test/wpt/status/streams.json +++ b/test/wpt/status/streams.json @@ -1,11 +1,4 @@ { - "idlharness.any.js": { - "fail": { - "expected": [ - "ReadableStream interface: operation from(any)" - ] - } - }, "idlharness-shadowrealm.window.js": { "skip": "ShadowRealm support is not enabled" }, From 18265c8cee9863da01d90e3050cc582b3f0722f6 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Sat, 18 Nov 2023 00:15:31 +0100 Subject: [PATCH 3/4] test: add note about readable streams with type owning --- test/wpt/status/streams.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json index fa97eae8320d78..f2248860de321e 100644 --- a/test/wpt/status/streams.json +++ b/test/wpt/status/streams.json @@ -17,6 +17,7 @@ }, "readable-streams/owning-type-message-port.any.js": { "fail": { + "note": "Readable streams with type owning are not yet supported", "expected": [ "Transferred MessageChannel works as expected", "Second branch of owning ReadableStream tee should end up into errors with transfer only values" @@ -28,6 +29,7 @@ }, "readable-streams/owning-type.any.js": { "fail": { + "note": "Readable streams with type owning are not yet supported", "expected": [ "ReadableStream can be constructed with owning type", "ReadableStream of type owning should call start with a ReadableStreamDefaultController", From ab162f6e3f0dff22937d48e81b8fdc984aba60d1 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Sat, 18 Nov 2023 11:07:43 +0100 Subject: [PATCH 4/4] test: add note about unresolved spec issue --- test/wpt/status/streams.json | 1 + 1 file changed, 1 insertion(+) diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json index f2248860de321e..3b6e0ce6429f9d 100644 --- a/test/wpt/status/streams.json +++ b/test/wpt/status/streams.json @@ -4,6 +4,7 @@ }, "piping/general-addition.any.js": { "fail": { + "note": "Blocked on https://github.com/whatwg/streams/issues/1243", "expected": [ "enqueue() must not synchronously call write algorithm" ]