wasi: fix up wasi tests for ibmi #49953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
@richardlau as discussed. |
richardlau
approved these changes
Sep 29, 2023
anonrig
approved these changes
Sep 29, 2023
lpinca
approved these changes
Sep 29, 2023
github-actions
bot
removed
the
request-ci
richardlau
reviewed
Sep 29, 2023
This was referenced Sep 30, 2023
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
18 tasks
|
@richardlau will take another look to figure out what is going on. |
|
Turns out the problem is that a newer version of the wasi-sdk has changed behaviour. I used the latest which was version 20. The docs dont' say what version was used before. I'll update the PR to fix up to work with wasi-sdk version 20 and to document that is the version which should be used. |
mhdawson
force-pushed
the
fixuvwasi-ibmi
branch
from
e66205b
to
44a5528
Compare
|
Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms. |
ibmi now reports os400 instead of aix
- update platform check in poll to allow for os400
- update wasi-sdk level to 20
- document the level of wasi-sdk used to compile the tests
- remove platform check in readdir test as it does not seem to be
needed with wasi-sdk version 20
- comment out tests for some clocks which are no longer available when
compiling with wasi-sdk level 20. These may be added back after
WebAssembly/wasi-libc#266 is resolved.
Signed-off-by: Michael Dawson <[email protected]>
mhdawson
force-pushed
the
fixuvwasi-ibmi
branch
from
44a5528
to
7873db3
Compare
mhdawson
force-pushed
the
fixuvwasi-ibmi
branch
from
7873db3
to
d7650a3
Compare
github-actions
bot
removed
the
request-ci
14 tasks
This looks good sans the linter failure. |
Signed-off-by: Michael Dawson <[email protected]>
|
Pushed commit to fix linter complaint. |
richardlau
approved these changes
Oct 4, 2023
github-actions
bot
removed
the
request-ci
|
osx failure looks like a flaky test - created this issue to track it - #50040 |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9cb8eb7 |
This was referenced Oct 5, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
ibmi now reports os400 instead of aix
- update platform check in poll to allow for os400
- update wasi-sdk level to 20
- document the level of wasi-sdk used to compile the tests
- remove platform check in readdir test as it does not seem to be
needed with wasi-sdk version 20
- comment out tests for some clocks which are no longer available when
compiling with wasi-sdk level 20. These may be added back after
WebAssembly/wasi-libc#266 is resolved.
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
ibmi now reports os400 instead of aix
- update platform check in poll to allow for os400
- update wasi-sdk level to 20
- document the level of wasi-sdk used to compile the tests
- remove platform check in readdir test as it does not seem to be
needed with wasi-sdk version 20
- comment out tests for some clocks which are no longer available when
compiling with wasi-sdk level 20. These may be added back after
WebAssembly/wasi-libc#266 is resolved.
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #49953
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
ibmi now reports os400 instead of aix
- update platform check in poll to allow for os400
- update wasi-sdk level to 20
- document the level of wasi-sdk used to compile the tests
- remove platform check in readdir test as it does not seem to be
needed with wasi-sdk version 20
- comment out tests for some clocks which are no longer available when
compiling with wasi-sdk level 20. These may be added back after
WebAssembly/wasi-libc#266 is resolved.
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibmi now reports os400 instead of aix