-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: migrate message source map tests from Python to JS #49238
test: migrate message source map tests from Python to JS #49238
Conversation
Thanks for this work! I don't think we need to make such an effort for git to detect these as renames as long as reviewing these PRs makes sense and doesn't include hundreds of files :) also, please fix lint errors and amend the commit message for it to comply with guidlines |
Thanks for your review. I have updated the commit message and the code according to Lint. |
46d42ca
to
bee982b
Compare
commits still don't adhere guidelines |
0a273de
to
e154b45
Compare
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: nodejs#47707 test: migrate message source map tests from Python to JS
e154b45
to
0991cb3
Compare
I squashed my commits, hope it works this time. |
Hi @MoLow, how can I pass the failed tests? |
I ran a rebuild |
Landed in 9cd70f4 |
@yiyunlei thanks for your contribution! |
@MoLow Thanks for your review! |
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: #47707 test: migrate message source map tests from Python to JS PR-URL: #49238 Reviewed-By: Moshe Atlow <[email protected]>
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: nodejs#47707 test: migrate message source map tests from Python to JS PR-URL: nodejs#49238 Reviewed-By: Moshe Atlow <[email protected]>
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: #47707 test: migrate message source map tests from Python to JS PR-URL: #49238 Reviewed-By: Moshe Atlow <[email protected]>
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: nodejs/node#47707 test: migrate message source map tests from Python to JS PR-URL: nodejs/node#49238 Reviewed-By: Moshe Atlow <[email protected]>
Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: nodejs/node#47707 test: migrate message source map tests from Python to JS PR-URL: nodejs/node#49238 Reviewed-By: Moshe Atlow <[email protected]>
Some JS files are detected as deleted and newly created even though they are very similar. I also mentioned the reason here #47707 (comment). IMHO, it is because the default similarity index for
git diff
is 50%.Same for most
.snapshot
files ( they are also detected as deleted ), the main difference between the original.out
file and the.snapshot
file is.snapshot
files have more details likeObject.<anonymous>
.Example:
node/test/fixtures/source-map/output/source_map_throw_catch.snapshot
node/test/message/source_map_throw_catch.out
Should I replace these
Object.<anonymous>
?Also, #47707 (comment)