-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: add a fast-path for readFileSync utf-8 #48658
Conversation
3ecaadc
to
1227128
Compare
@santigimeno @bnoordhuis One of the tests failing and throwing Stack trace
|
great work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I would recommend a CITGM run anyway
Is this PR worth having a |
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. |
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
Backport-PR-URL: nodejs#48658
This pull request improves the performance of
fs.readFileSync
for UTF-8 encoding.Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1346