Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: fix dependabot commit message #47810

Merged
merged 1 commit into from
May 2, 2023
Merged

meta: fix dependabot commit message #47810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@ updates:
directory: /
schedule:
interval: monthly
commit-message:
prefix: meta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, we've used build: for the GitHub Actions stuff, but I'm fine with meta: or build:. Mentioning it in case anyone has a strong opinion about which one we should standardize on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think meta: or tools: are better than build:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tools: would be better to use here over the others for the sake of consistency as we've been using tools: way more than others lately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I believe the primary reason for using tools: has been that the main logic of recent commits is in tools/dep_updaters/. IMO neither tools: nor build: seems really fitting for GitHub actions that are not directly related to our build process, nor tools that we use outside of GitHub actions.

open-pull-requests-limit: 10