Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove spaces from test runner test names #47733

Merged
merged 1 commit into from
Apr 27, 2023
Merged

test: remove spaces from test runner test names #47733

merged 1 commit into from
Apr 27, 2023

Conversation

tniessen
Copy link
Member

No description provided.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 26, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

MoLow
MoLow approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51503/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit 36e4e3d into nodejs:main Apr 27, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 36e4e3d

@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Open
29 tasks
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@tniessen @yjl9903
test: remove spaces from test runner test names
0170fff 
PR-URL: nodejs#47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
@tniessen @yjl9903
test: remove spaces from test runner test names
388176c 
PR-URL: nodejs#47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Open
32 tasks
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@tniessen @yjl9903
test: remove spaces from test runner test names
c2c7d23 
PR-URL: nodejs#47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 30, 2023
Open
33 tasks
This was referenced May 1, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@tniessen @targos
test: remove spaces from test runner test names
79e5a16 
PR-URL: #47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2023
Open
33 tasks
targos pushed a commit that referenced this pull request May 3, 2023
@tniessen @targos
test: remove spaces from test runner test names
5bb7b26 
PR-URL: #47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
test: remove spaces from test runner test names
cb76f4f 
PR-URL: #47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@tniessen @MoLow
test: remove spaces from test runner test names
d669714 
PR-URL: nodejs#47733
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@MoLow MoLow MoLow approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @GeoffreyBooth @lpinca @richardlau @deokjinkim @MoLow @KhafraDev