test_runner: remove no-op validation #47687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code already checks if testNamePatterns is an array, and converts it to an array if it is not.
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
targos
approved these changes
Apr 23, 2023
benjamingr
approved these changes
Apr 23, 2023
MoLow
approved these changes
Apr 23, 2023
debadree25
approved these changes
Apr 23, 2023
debadree25
added
author ready
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Apr 23, 2023
deokjinkim
approved these changes
Apr 24, 2023
aymen94
approved these changes
Apr 24, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ab3a54f |
29 tasks
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: nodejs#47687 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: nodejs#47687 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 29, 2023
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: nodejs#47687 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: #47687 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: #47687 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The code already checks if testNamePatterns is an array, and converts it to an array if it is not. PR-URL: nodejs#47687 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Deokjin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code already checks if
testNamePatternsis an array, and converts it to an array if it is not.