esm: remove support for deprecated hooks #47580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those have been deprecated for a while, it's time.
|
Review requested:
|
nodejs-github-bot
added
esm
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
VoltrexKeyva
approved these changes
Apr 16, 2023
targos
approved these changes
Apr 16, 2023
|
If we don't backport this, it might be hard to backport future loaders work. The whole API is still experimental, I think this can be backported. |
GeoffreyBooth
approved these changes
Apr 16, 2023
anonrig
approved these changes
Apr 16, 2023
jasnell
approved these changes
Apr 17, 2023
35 tasks
aduh95
added
experimental
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7dd3732 |
This was referenced Apr 24, 2023
targos
pushed a commit
that referenced
this pull request
May 2, 2023
Those have been deprecated for a while, it's time. PR-URL: #47580 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
added
the
backport-requested-v18.x
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 11, 2023
Those have been deprecated for a while, it's time. PR-URL: nodejs#47580 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added
backported-to-v18.x
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
Those have been deprecated for a while, it's time. PR-URL: #47580 Backport-PR-URL: #50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Those have been deprecated for a while, it's time. PR-URL: nodejs/node#47580 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Those have been deprecated for a while, it's time. PR-URL: nodejs/node#47580 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those have been deprecated for a while, it's time.