Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: test promise null-checks #47553

Closed
wants to merge 1 commit into from
Closed

node-api: test promise null-checks #47553

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Also adds a missing check for deferred being NULL during resolution.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2023 •
edited by gabrielschulhof
Loading

Review requested:

  • @nodejs/gyp
  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Apr 13, 2023
@gabrielschulhof gabrielschulhof marked this pull request as draft April 13, 2023 22:07
@gabrielschulhof gabrielschulhof added the test Issues and PRs related to the tests. label Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51243/

@gabrielschulhof gabrielschulhof marked this pull request as ready for review April 14, 2023 03:27
@gabrielschulhof
node-api: test promise null-checks
43be6fe 
Also adds a missing check for deferred being NULL during resolution.
This was referenced Apr 15, 2023
Open
Open
mhdawson
mhdawson approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51329/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51371/

@gabrielschulhof
Copy link
Contributor Author

Landed in ef17b4c.

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request May 13, 2023
@gabrielschulhof
node-api: test promise null-checks
ef17b4c 
Also adds a missing check for deferred being NULL during resolution.

Signed-off-by: Gabriel Schulhof <[email protected]>
PR-URL: nodejs#47553
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrielschulhof @nodejs-github-bot @legendecas @mhdawson