tools: fix notify-on-push Slack messages #47453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
richardlau
approved these changes
Apr 6, 2023
aduh95
added
author ready
debadree25
approved these changes
Apr 6, 2023
anonrig
approved these changes
Apr 6, 2023
Trott
reviewed
Apr 7, 2023
| @@ -51,7 +51,7 @@ jobs: | |||
| if: ${{ env.PR_ID }} | |||
| run: | | |||
| gh pr comment ${{ env.PR_ID }} --repo "${{ github.repository }}" \ | |||
| --body "A commit referencing this Pull Request was pushed to `main` by @${{ github.actor }} without the expected commit metadata added to its message." | |||
| --body "A commit referencing this Pull Request was pushed to `${{ github.ref_name }}` by @${{ github.actor }} with an invalid commit message." | |||
There was a problem hiding this comment.
Non-blocking: Would it be better to say that the commit message failed linting and/or that it is in an invalid format rather than saying "invalid commit message"?
nodejs-github-bot
removed
the
commit-queue
|
Landed in 57caf13 |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47453 Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47453 Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47453 Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@heremention was not working. Also saying the commit is "lacking the expected metadata" is not always true, as lacking metadata is one of several things the workflow is checking.Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions