Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: info on handling unintended breaking changes #47426

Merged
merged 2 commits into from
Apr 9, 2023
Merged

doc: info on handling unintended breaking changes #47426

merged 2 commits into from
Apr 9, 2023

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Apr 5, 2023

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 5, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2023
mcollina
mcollina approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47426
✔  Done loading data for nodejs/node/pull/47426
----------------------------------- PR info ------------------------------------
Title      doc: info on handling unintended breaking changes (#47426)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:breaking-changes -> nodejs:main
Labels     doc, author ready
Commits    2
 - doc: info on handling unintended breaking changes
 - Update doc/contributing/collaborator-guide.md
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/47426
Fixes: https://github.com/nodejs/TSC/issues/1156
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47426
Fixes: https://github.com/nodejs/TSC/issues/1156
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 05 Apr 2023 19:12:04 GMT
   ✔  Approvals: 6
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47426#pullrequestreview-1373595089
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/47426#pullrequestreview-1373615386
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/47426#pullrequestreview-1373644856
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47426#pullrequestreview-1374637778
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/47426#pullrequestreview-1376543820
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47426#pullrequestreview-1376789264
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47426
From https://github.com/nodejs/node
 * branch                  refs/pull/47426/merge -> FETCH_HEAD
✔  Fetched commits as 491a5c968fd4..4410a2875487
--------------------------------------------------------------------------------
[main 9ad35bbb95] doc: info on handling unintended breaking changes
 Author: Michael Dawson 
 Date: Wed Apr 5 15:04:42 2023 -0400
 1 file changed, 18 insertions(+)
[main 22ebdb5d4c] Update doc/contributing/collaborator-guide.md
 Author: Michael Dawson 
 Date: Thu Apr 6 11:14:25 2023 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

⚠  Found Fixes: nodejs/TSC#1156, skipping..

--------------------------------- New Message ----------------------------------

doc: info on handling unintended breaking changes


Fixes: nodejs/TSC#1156

PR-URL: #47426

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Marco Ippolito [email protected]

Reviewed-By: Debadree Chatterjee [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Rafael Gonzaga [email protected]


[detached HEAD 2f2d209148] doc: info on handling unintended breaking changes

Author: Michael Dawson [email protected]

Date: Wed Apr 5 15:04:42 2023 -0400

1 file changed, 18 insertions(+)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/contributing/collaborator-guide.md


Co-authored-by: Mohammed Keyvanzadeh [email protected]

PR-URL: #47426

Fixes: nodejs/TSC#1156

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Marco Ippolito [email protected]

Reviewed-By: Debadree Chatterjee [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Rafael Gonzaga [email protected]


[detached HEAD ea88441904] Update doc/contributing/collaborator-guide.md

Author: Michael Dawson [email protected]

Date: Thu Apr 6 11:14:25 2023 -0400

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/4651978867

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6c76d7e into nodejs:main Apr 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6c76d7e

@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@mhdawson @RafaelGSS
doc: info on handling unintended breaking changes
c7ad5bb 
Fixes: nodejs/TSC#1156
PR-URL: #47426
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@mhdawson @danielleadams
doc: info on handling unintended breaking changes
6a4f64e 
Fixes: nodejs/TSC#1156
PR-URL: #47426
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@mhdawson @MoLow
doc: info on handling unintended breaking changes
3902be8 
Fixes: nodejs/TSC#1156
PR-URL: nodejs#47426
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@debadree25 debadree25 debadree25 approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling unintended breaking changes
9 participants
@mhdawson @nodejs-github-bot @mcollina @benjamingr @lpinca @debadree25 @RafaelGSS @marco-ippolito @VoltrexKeyva