Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-cluster-primary-error flaky on asan #47422

Merged
merged 1 commit into from
Apr 14, 2023
Merged

test: mark test-cluster-primary-error flaky on asan #47422

merged 1 commit into from
Apr 14, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 5, 2023

mitigation for #39655

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 5, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50975/

@richardlau
Copy link
Member

mitigation for #39655

AIX has nothing to do with the ASAN GitHub workflow.

@anonrig
Copy link
Member Author

anonrig commented Apr 5, 2023

AIX has nothing to do with the ASAN GitHub workflow.

@richardlau I couldn't find any reference in the parallel.status for ASAN. Should I add a new section with [$system==asan]?

@richardlau
Copy link
Member

AIX has nothing to do with the ASAN GitHub workflow.

@richardlau I couldn't find any reference in the parallel.status for ASAN. Should I add a new section with [$system==asan]?

That probably won't work. System is from

node/tools/test.py

Lines 1671 to 1676 in ead4079

env = {
'mode': mode,
'system': utils.GuessOS(),
'arch': vmArch,
'type': get_env_type(vm, options.type, context),
}
.

I have no idea how to represent ASAN builds in the status files.

@anonrig anonrig added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 5, 2023
@Trott
Copy link
Member

Trott commented Apr 5, 2023 •
edited
Loading

@anonrig You very well might already know this already, but just in case: ASan stands for "Address Sanitizer". More information is at https://clang.llvm.org/docs/AddressSanitizer.html. Hope that helps in figuring out either how to fix the text/issue or else how to detect ASan runs so things can be skipped if necessary.

Looking at https://github.com/nodejs/node/blob/ead407915e510014e5294dd4446e29d8f3f04bdc/.github/workflows/test-asan.yml, it seems an easy-ish way to detect an ASan build might be to check for --enable-asan in config.status.

@anonrig anonrig force-pushed the make-cluster-flaky branch 3 times, most recently from 1f8102d to d043490 Compare April 5, 2023 21:42
@anonrig anonrig changed the title test: mark test-cluster-primary-error flaky on aix test: mark test-cluster-primary-error flaky on asan Apr 5, 2023
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Apr 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51221/

@anonrig
Copy link
Member Author

anonrig commented Apr 13, 2023

I fixed the issue. Appreciate if you can review this PR again...

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51232/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51237/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51242/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit c94be41 into nodejs:main Apr 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in c94be41

This was referenced Apr 15, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig @targos
test: mark test-cluster-primary-error flaky on asan
826f404 
PR-URL: #47422
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig @danielleadams
test: mark test-cluster-primary-error flaky on asan
6fd0cdf 
PR-URL: #47422
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig @MoLow
test: mark test-cluster-primary-error flaky on asan
3a9c43a 
PR-URL: nodejs#47422
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@VoltrexKeyva VoltrexKeyva Awaiting requested review from VoltrexKeyva

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @richardlau @Trott @jasnell @MoLow @VoltrexKeyva