-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: move update-acorn.sh to dep_updaters #47382
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:feat/update-acorn
Apr 10, 2023
Merged
tools: move update-acorn.sh to dep_updaters #47382
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:feat/update-acorn
Apr 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
meta
Issues and PRs related to the general management of the project.
tools
Issues and PRs related to the tools directory.
labels
Apr 3, 2023
Can you please make the commit message clearer? |
targos
reviewed
Apr 3, 2023
targos
reviewed
Apr 3, 2023
marco-ippolito
force-pushed
the
feat/update-acorn
branch
from
April 3, 2023 12:47
88a6f77
to
e2a8f16
Compare
marco-ippolito
force-pushed
the
feat/update-acorn
branch
from
April 3, 2023 12:49
e2a8f16
to
2b14a6a
Compare
marco-ippolito
changed the title
tools: maintaining acorn
tools: move update-acorn.sh to dep_updaters
Apr 3, 2023
ShogunPanda
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
marco-ippolito
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 7, 2023
RafaelGSS
approved these changes
Apr 8, 2023
lpinca
approved these changes
Apr 10, 2023
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 10, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 10, 2023
Landed in c2b54fb |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47382 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47382 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47382 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
meta
Issues and PRs related to the general management of the project.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828
@nodejs/security-wg