Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix Slack notification action #47237

Merged
merged 2 commits into from
Mar 23, 2023
Merged

tools: fix Slack notification action #47237

merged 2 commits into from
Mar 23, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 23, 2023

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 23, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 23, 2023

I tested it this time: aduh95/node-auto-test#1 (comment)

@debadree25
Copy link
Member

debadree25 commented Mar 23, 2023 •
edited
Loading

Should we fast-track this? adding the fast-track label for now, feel free to remove if deemed not ncessary

@debadree25 debadree25 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @debadree25. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 946f0ca into nodejs:main Mar 23, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 946f0ca

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@aduh95 @RafaelGSS
tools: fix Slack notification action
0f2eff2 
PR-URL: #47237
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
@aduh95 aduh95 deleted the notify-invalid-commit branch April 6, 2023 15:06
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@aduh95 @RafaelGSS
tools: fix Slack notification action
0c613c9 
PR-URL: #47237
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@aduh95 @danielleadams
tools: fix Slack notification action
816e215 
PR-URL: #47237
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @debadree25 @MoLow