test: s390x zlib test case fixes #46367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to nodejs#44117 and addresses the indeterminate nature of the hardware accelerated compression.
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jan 26, 2023
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 223dc69 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression. PR-URL: #46367 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression. PR-URL: #46367 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression. PR-URL: #46367 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression. PR-URL: #46367 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #44117 and addresses the indeterminate nature of the hardware accelerated compression.
The fix looks kind of ugly but I wanted to keep the asserts the same.