-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add missing line in debugger #45632
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:1127_add_missing_line_debugger
Nov 30, 2022
Merged
doc: add missing line in debugger #45632
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:1127_add_missing_line_debugger
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output of "node inspect" missed "connecting to..." line from time to time. So added it.
nodejs-github-bot
added
debugger
Issues and PRs related to the debugger subsystem.
doc
Issues and PRs related to the documentations.
labels
Nov 26, 2022
cola119
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cola119
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 27, 2022
jasnell
approved these changes
Nov 27, 2022
cola119
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 30, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 30, 2022
Landed in 1b550ba |
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Nov 30, 2022
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: nodejs#45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: #45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: #45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: #45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: #45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: #45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: #45632 Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
debugger
Issues and PRs related to the debugger subsystem.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of "node inspect" missed "connecting to..." line from time to time.
So added it.