Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: set an appropriate thread pool size if given --v8-pool-size=0 #45513

Merged
merged 2 commits into from
Nov 21, 2022
Merged

src: set an appropriate thread pool size if given --v8-pool-size=0 #45513

merged 2 commits into from
Nov 21, 2022

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Nov 19, 2022

Node.js doesn't terminate when any pending V8 tasks exist if no thread is in the pool.

This allocates one thread at least for the tasks if --v8-pool-size=0 is given as a CLI option.

Fixes: #42523
Alternative to #42524

Signed-off-by: Daeyeon Jeong [email protected]

@daeyeon
src: set an appropriate thread pool size if given --v8-pool-size=0
c57a161 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 19, 2022
@daeyeon
Copy link
Member Author

daeyeon commented Nov 19, 2022

/cc @nodejs/cpp-reviewers

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48022/

@github-actions github-actions bot mentioned this pull request Nov 20, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48031/

@daeyeon daeyeon added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48039/

RafaelGSS
RafaelGSS approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2022
@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Open
15 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 47d3adb into nodejs:main Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 47d3adb

@daeyeon daeyeon deleted the main.thread-pool-221118.Fri.def2 branch November 21, 2022 03:52
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@daeyeon @ruyadorno
src: set an appropriate thread pool size if given --v8-pool-size=0
56f22ea 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45513
Fixes: #42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Open
15 tasks
@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Open
13 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@daeyeon @marco-ippolito
src: set an appropriate thread pool size if given --v8-pool-size=0
e83a5e8 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#45513
Fixes: nodejs#42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@daeyeon @danielleadams
src: set an appropriate thread pool size if given --v8-pool-size=0
641fb08 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45513
Fixes: #42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@daeyeon @danielleadams
src: set an appropriate thread pool size if given --v8-pool-size=0
d829eb0 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45513
Fixes: #42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@daeyeon @danielleadams
src: set an appropriate thread pool size if given --v8-pool-size=0
0328208 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45513
Fixes: #42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@daeyeon @danielleadams
src: set an appropriate thread pool size if given --v8-pool-size=0
90670ea 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45513
Fixes: #42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@daeyeon @danielleadams
src: set an appropriate thread pool size if given --v8-pool-size=0
910600a 
It doesn't terminate when any pending V8 tasks exist if no thread
is in the pool.

This allocates one thread at least for V8's background tasks if
`--v8-pool-size=0` is given as a CLI option.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #45513
Fixes: #42523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run worker threads with --v8-pool-size=0
8 participants
@daeyeon @nodejs-github-bot @bnoordhuis @santigimeno @anonrig @richardlau @RafaelGSS @aduh95