Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: forbid running watch mode in REPL #45058

Merged
merged 2 commits into from
Oct 20, 2022
Merged

src: forbid running watch mode in REPL #45058

merged 2 commits into from
Oct 20, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 18, 2022

Fixes: #45006

@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 18, 2022
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
VoltrexKeyva
VoltrexKeyva reviewed Oct 19, 2022
View reviewed changes
src/node_options.cc Outdated Show resolved Hide resolved
@MoLow @VoltrexKeyva
Update src/node_options.cc
ca4d76b 
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 20, 2022
Open
10 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47354/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47357/

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2022
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45058
✔  Done loading data for nodejs/node/pull/45058
----------------------------------- PR info ------------------------------------
Title      src: forbid running watch mode in REPL (#45058)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:watch-mode-no-repl -> nodejs:main
Labels     c++, author ready, needs-ci, watch-mode
Commits    2
 - src: forbid running watch mode in REPL
 - Update src/node_options.cc
Committers 2
 - Moshe Atlow 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/45058
Fixes: https://github.com/nodejs/node/issues/45006
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45058
Fixes: https://github.com/nodejs/node/issues/45006
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 18 Oct 2022 17:52:51 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45058#pullrequestreview-1146304597
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45058#pullrequestreview-1148792149
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-20T07:11:55Z: https://ci.nodejs.org/job/node-test-pull-request/47357/
- Querying data for job/node-test-pull-request/47357/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 45058
From https://github.com/nodejs/node
 * branch                  refs/pull/45058/merge -> FETCH_HEAD
✔  Fetched commits as e7645fab79be..ca4d76b22f30
--------------------------------------------------------------------------------
[main f5f00b59ea] src: forbid running watch mode in REPL
 Author: Moshe Atlow 
 Date: Tue Oct 18 17:52:15 2022 +0000
 4 files changed, 27 insertions(+), 20 deletions(-)
[main c8e659e9cf] Update src/node_options.cc
 Author: Moshe Atlow 
 Date: Wed Oct 19 15:10:53 2022 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

src: forbid running watch mode in REPL


PR-URL: #45058

Fixes: #45006

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]


[detached HEAD 0f4d6682c9] src: forbid running watch mode in REPL

Author: Moshe Atlow [email protected]

Date: Tue Oct 18 17:52:15 2022 +0000

4 files changed, 27 insertions(+), 20 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update src/node_options.cc


Co-authored-by: Mohammed Keyvanzadeh [email protected]

PR-URL: #45058

Fixes: #45006

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]


[detached HEAD 0ed701487e] Update src/node_options.cc

Author: Moshe Atlow [email protected]

Date: Wed Oct 19 15:10:53 2022 +0300

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/3291957192

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 20, 2022
@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit c8264ad into nodejs:main Oct 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in c8264ad

@MoLow MoLow deleted the watch-mode-no-repl branch October 20, 2022 18:40
This was referenced Oct 21, 2022
Open
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@MoLow @RafaelGSS
src: forbid running watch mode in REPL
c366b70 
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@MoLow @RafaelGSS
src: forbid running watch mode in REPL
a8412f5 
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
src: forbid running watch mode in REPL
542af84 
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
src: forbid running watch mode in REPL
0b43ec8 
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@MoLow @danielleadams
src: forbid running watch mode in REPL
169b33a 
PR-URL: #45058
Fixes: #45006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@ErickWendel ErickWendel Awaiting requested review from ErickWendel

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--watch mode shouldn't enter REPL, causes a crash
5 participants
@MoLow @nodejs-github-bot @jasnell @benjamingr @VoltrexKeyva