Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: clarify OptionEnvvarSettings member names #45057

Merged
merged 1 commit into from
Oct 27, 2022

Commits on Oct 24, 2022

  1. src: clarify OptionEnvvarSettings member names

    The term `Environment` in `kAllowedInEnvironment` and
    `kDisallowedInEnvironment` has nothing to do with the commonly used
    term `node::Environment`. Rename the member to `kAllowedInEnvvar`
    and `kDisallowedInEnvvar` respectively to reflect they are options
    of `OptionEnvvarSettings`.
    
    As `OptionEnvvarSettings` is part of the public embedder APIs, the
    legacy names are still preserved.
    legendecas committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    cb039c2 View commit details
    Browse the repository at this point in the history