test: async iife in repl

[tony-go]

Context

Fixes: #38685

The previous PR has more than ten months, it's why I decided to jump on it.

Improvements

A regression test ensures that async IFEE will work on the REPL.

cc @addaleax

[RaisinTen]

Should we use Closes or Fixes in the PR description instead of Ref so that merging this PR automatically closes the issue?

[RaisinTen]

Do you know the Node.js version for which this test would crash? It only affects debug builds, so it would probably require building Node.js locally for confirming that this is actually a regression test for the issue.

Seeing #38685 (comment) it appears that it got fixed later on, so I'm curious what the fix was.

[tony-go]

Hey @RaisinTen 👋

Honestly I don't have a clue on this :/

Maybe @addaleax could provide the version.

[targos]

it affected the master branch in May 2021, so I would try with v14.0.0.

[tony-go]

Thanks @targos :)

Should I checkout the v14 branch and run the test it and see if it fails?

[tony-go]

Hey 👋🏼

I could not make the test fail on 14.0.0 as advised @targos or with 17.0.0 as mentioned in the issue of @addaleax.

Should I close it so? cc @RaisinTen

[tony-go]

Nvm, I didn't test with debug build :/

[tony-go]

I finally build from sources for v14.0.0 and v17.0.0 on mac:

➜  ./node
Welcome to Node.js v14.0.0.
Type ".help" for more information.
> (async() => { })()
Promise { undefined }
>

➜  ./node
Welcome to Node.js v17.0.0.
Type ".help" for more information.
> (async() => { })()
Promise {
  undefined,
  [Symbol(async_id_symbol)]: 26,
  [Symbol(trigger_async_id_symbol)]: 5,
  [Symbol(destroyed)]: { destroyed: false }
}
>

Maybe I should try on my Fedora machine...

[aduh95]

@tony-go maybe you can try to spawn a subprocess with --interactive flag instead of using node:repl?

[tony-go]

@tony-go maybe you can try to spawn a subprocess with --interactive flag instead of using node:repl?

Yeah, good idea @aduh95 :) I just wonder if the PR still makes sense as I was not able to reproduce it: #44878 (comment)

Even if I think that it is sill relevant to have tests anyway? WDYT?

[aduh95]

@tony-go what I meant was that maybe you would be able to reproduce on v14.x if you were using -i

[tony-go]

@tony-go what I meant was that maybe you would be able to reproduce on v14.x if you were using -i

Okay I did not get it this way, but yeah I'll try this :)

[tony-go]

Hey @aduh95 👋🏼

I could not make it crash on version 14 and the --interactive flag.

:/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55301/

[jasnell]

No updates on this in over a year. Needs to be revisited. Removed the author ready label.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63421/