-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove unused variable in addon test #44809
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
joyeecheung:remove-unused-isolate
Oct 2, 2022
Merged
test: remove unused variable in addon test #44809
nodejs-github-bot
merged 1 commit into
nodejs:main
from
joyeecheung:remove-unused-isolate
Oct 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the compiler warning for the unused variable in the report-api addon test.
nodejs-github-bot
added
addons
Issues and PRs related to native addons.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Sep 28, 2022
richardlau
approved these changes
Sep 28, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 28, 2022
lpinca
approved these changes
Sep 28, 2022
tniessen
approved these changes
Sep 28, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 28, 2022
cjihrig
approved these changes
Sep 28, 2022
daeyeon
approved these changes
Sep 29, 2022
16 tasks
tniessen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 29, 2022
Trott
approved these changes
Sep 29, 2022
This was referenced Sep 30, 2022
jasnell
approved these changes
Oct 2, 2022
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 2, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 2, 2022
Landed in a16f81e |
9 tasks
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
This fixes the compiler warning for the unused variable in the report-api addon test. PR-URL: #44809 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addons
Issues and PRs related to native addons.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the compiler warning for the unused variable in the report-api addon test.