test:update test-debugger-random-port-with-inspect-port.js to use awa… #44695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
tniessen
added
the
code-and-learn
Qard
reviewed
Sep 17, 2022
Monu-Chaudhary
force-pushed
the
update-test-debugger-random-port-with-inspect-port.js-to-use-async-await
branch
from
c3ea0bd
to
a534721
Compare
Qard
reviewed
Sep 18, 2022
Monu-Chaudhary
force-pushed
the
update-test-debugger-random-port-with-inspect-port.js-to-use-async-await
branch
from
a534721
to
a829160
Compare
Trott
force-pushed
the
update-test-debugger-random-port-with-inspect-port.js-to-use-async-await
branch
from
fd043e7
to
8bbb1c3
Compare
Trott
reviewed
Sep 28, 2022
Trott
added
the
commit-queue-squash
Trott
reviewed
Sep 28, 2022
Trott
approved these changes
Sep 28, 2022
Trott
added
author ready
github-actions
bot
removed
the
request-ci
16 tasks
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/44695 ✔ Done loading data for nodejs/node/pull/44695 ----------------------------------- PR info ------------------------------------ Title test:update test-debugger-random-port-with-inspect-port.js to use awa… (#44695) Author Monu Chaudhary (@Monu-Chaudhary, first-time contributor) Branch Monu-Chaudhary:update-test-debugger-random-port-with-inspect-port.js-to-use-async-await -> nodejs:main Labels test, code-and-learn, author ready, needs-ci, commit-queue-squash Commits 3 - test: use async/await in test-debugger-random-port-with-inspect-port - Update test/sequential/test-debugger-random-port-with-inspect-port.js - Update test/sequential/test-debugger-random-port-with-inspect-port.js Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/44695 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44695 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Sep 2022 22:27:18 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44695#pullrequestreview-1124288486 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-29T13:36:43Z: https://ci.nodejs.org/job/node-test-pull-request/46935/ - Querying data for job/node-test-pull-request/46935/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @Monu-Chaudhary([email protected]) ⚠ - commit 7581012aed7f is authored by [email protected] ⚠ - commit a912115cd4b1 is authored by [email protected] -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3153482977 |
nodejs-github-bot
added
the
commit-queue-failed
PR-URL: nodejs#44695 Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
update-test-debugger-random-port-with-inspect-port.js-to-use-async-await
branch
from
a912115
to
6b9253a
Compare
|
Landed in 6b9253a |
|
Thanks for the contribution! 🎉 |
This was referenced Sep 30, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44695 Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it/async
editor signed-off-by: Monu Chaudhary [email protected]