test: make tmpdir.js importable with destructuring/named export

[GeoffreyBooth]

Very small PR to fix that test/common/tmpdir.js throws this error if you run its refresh() from an ESM test:

~/node/test/common/tmpdir.js:22
  rmSync(this.path);
              ^

TypeError: Cannot read properties of undefined (reading 'path')

I’m not sure why this was written to use this.path in the first place, since when I inspect it it always seems to be the same value as tmpPath defined just above; so I put that in instead. Seems like a simple fix and gets rid of this error. (I’m working on a separate PR that imports this file from an ESM test, which is why I needed this fixed.)

You can reproduce this by creating test/foo.mjs as follows:

import { refresh } from './common/tmpdir.js';
refresh();

And running it via ./node test/foo.mjs

---

A perhaps bigger question for @nodejs/modules and @nodejs/loaders is why the value of this within this function varies based on whether the file is imported by a CommonJS consumer as opposed to an ESM consumer. I don’t think this is something to be resolved in this PR, but someone who understands this stuff better then me should please comment explaining why this is expected behavior (or if it’s not, then we should open a bug issue).

[Trott]

Might not be a bad idea to add a test for this bug fix. But it also might be a bit much. Your call. I'm good either way.

[aduh95]

The commit message is a bit misleading – this has nothing to do with ESM, and would fail as well with const { refresh } = require('./common/tmpdir').

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46129/

[Trott]

I don't know why the arm-fanned builds keep failing but I ran that job on this code separately rather than using Resume Build and it passed: https://ci.nodejs.org/job/node-test-commit-arm-fanned/26985/

Hopefully the run that is in progress now will pass, but if not, a Rebuild may be necessary if we want to get it to green (or we can agree that the build in the preceding paragraph is sufficient).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46130/

[Trott]

Hopefully the run that is in progress now will pass, but if not, a Rebuild may be necessary if we want to get it to green (or we can agree that the build in the preceding paragraph is sufficient).

It failed again. I'm running a full Rebuild out of an abundance of caution only (plus we have ~36 hours before this can land anyway, unless someone fast-tracks it).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46132/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46133/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46134/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46166/

[MoLow]

@GeoffreyBooth perhaps this should be rebased to make the CI pass?

[GeoffreyBooth]

@GeoffreyBooth perhaps this should be rebased to make the CI pass?

No, I’m sure if I just keep retrying it’ll eventually work. Or I’ll turn it off and on. 😄

I just rebased, but I don’t think it should make any difference; one of the options in the CI form is what branch to rebase on, so I think it always rebases as part of doing a CI run.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/44322
✔  Done loading data for nodejs/node/pull/44322
----------------------------------- PR info ------------------------------------
Title      test: make tmpdir.js importable with destructuring/named export (#44322)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     GeoffreyBooth:fix-test-tmpdir -> nodejs:main
Labels     test, esm, author ready
Commits    1
 - test: make tmpdir.js importable from esm
Committers 1
 - Geoffrey Booth 
PR-URL: https://github.com/nodejs/node/pull/44322
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
Reviewed-By: Ian Sutherland 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44322
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
Reviewed-By: Ian Sutherland 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 21 Aug 2022 02:38:01 GMT
   ✔  Approvals: 6
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44322#pullrequestreview-1079613907
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44322#pullrequestreview-1081133794
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44322#pullrequestreview-1079641751
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44322#pullrequestreview-1079712704
   ✔  - Ian Sutherland (@iansu): https://github.com/nodejs/node/pull/44322#pullrequestreview-1080915200
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44322#pullrequestreview-1081014059
   ✖  This PR needs to wait 2 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-08-22T20:44:57Z: https://ci.nodejs.org/job/node-test-pull-request/46166/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - test: make tmpdir.js importable from esm
- Querying data for job/node-test-pull-request/46166/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2907918493

[nodejs-github-bot]

Landed in 8e87299