Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add filesystem check to test-fs-stat-date.mjs #44174

Merged
merged 1 commit into from
Aug 14, 2022
Merged

test: add filesystem check to test-fs-stat-date.mjs #44174

merged 1 commit into from
Aug 14, 2022

Conversation

LiviaMedeiros
Copy link
Contributor

main-based alternative to: #44129

Skip the test if filesystem doesn't provide correct atime or mtime value from fs.stat().

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos targos mentioned this pull request Aug 8, 2022
Closed
@aduh95 aduh95 requested a review from richardlau August 8, 2022 15:01
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Aug 9, 2022
Open
8 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45949/

@LiviaMedeiros LiviaMedeiros added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@LiviaMedeiros
Copy link
Contributor Author

Marking as fast-track PRs that do not need to wait for 48 hours to land. in case if we need this in v16.17.0 before deadlines.

This was referenced Aug 10, 2022
Open
Open
Open
Open
Open
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Aug 14, 2022
@targos targos mentioned this pull request Aug 14, 2022
Merged
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit 86276d3 into nodejs:main Aug 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 86276d3

This was referenced Aug 15, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@LiviaMedeiros @danielleadams
test: add filesystem check to test-fs-stat-date.mjs
64300a6 
PR-URL: #44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@LiviaMedeiros @ruyadorno
test: add filesystem check to test-fs-stat-date.mjs
e373144 
PR-URL: #44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
targos pushed a commit that referenced this pull request Sep 5, 2022
@LiviaMedeiros @targos
test: add filesystem check to test-fs-stat-date.mjs
ab6a1a7 
PR-URL: #44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@LiviaMedeiros @Fyko
test: add filesystem check to test-fs-stat-date.mjs
e51b171 
PR-URL: nodejs#44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos
Copy link
Member

targos commented Sep 16, 2022

@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected.
See #44542 (comment)
https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

@LiviaMedeiros
Copy link
Contributor Author

According to #44129 (comment), this test platform uses NFS mounts.
According to RFC 1813, Page 21, NFSv3 uses unsigned types for timestamps:

      struct nfstime3 {
         uint32   seconds;
         uint32   nseconds;
      };

While NFSv4 (RFC 7530, Page 21) uses signed:

   struct nfstime4 {
           int64_t         seconds;
           uint32_t        nseconds;
   };

This is my best guess on why could this happen.

Opened #44707 against main, let me know if backport PR would be more convenient.

@richardlau richardlau mentioned this pull request Oct 7, 2022
Merged
@juanarbol
Copy link
Member

@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected. See #44542 (comment) https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

This is causing the CI to fail in the v16.x release branch. I will label this as dont-land-on-v16.x; feel free to remove it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LiviaMedeiros @nodejs-github-bot @targos @juanarbol @richardlau @aduh95